[Networkit] setup.py compiler detection cleanup
christian.staudt at kit.edu
Wed Nov 4 22:34:44 CET 2015
By the way: Are we ready for the “new” (almost a year old) C++14?
Today was the first time I wanted a feature from the C++14 standard: The [[deprecated]] attribute, which allows me to give outdated code a warning before I have to kill it.
I installed GCC 4.9 and switched the c++11 flags in the setup code to c++14. Works well for me, see the latest commit: https://algohub.iti.kit.edu/parco/NetworKit/NetworKit/changeset/ba32d6aabdf5230e5b66acb209e6de63284385f6
Any reasons why we shouldn’t upgrade? Reasons please, not “But I like my GCC 4.6”. The evolution of C++ is already very slow and careful.
On 03 Nov 2015, at 13:18, Maximilian Vogel <maximilian.vogel at student.kit.edu> wrote:
> On 03.11.2015 19:01, Matteo Riondato wrote:
>>> On Nov 3, 2015, at 12:54 PM, Jonas H. <jonas at lophus.org> wrote:
>>> My suggestion is to simply assume `g++` to work, maybe keep the “sample.cpp” check, add a note about the supported compilers to the documentation and respect the $CXX environment variable (or some `pip` option).
>> My suggestion: first check for $CXX (or whatever it is called these days), then fall back to g++ (checking for a min version, if required), then clang (checking for version >= 3.7, which supports openmp) and if didn’t find any, just fail.
>> As an example of why assuming a fixed set of compilers is wrong and unmaintainable: I run my NetworKit code on Mac OS X, Linux, and FreeBSD, and each of them uses different name for the g++-5 binary (resp. g++-mp-5, g++5, g++-5). Moreover, I sometimes test things with clang, just to be sure, and I have to modify the SConstruct script for every different choice.
> Thanks for your advice, you are totally right that the $CXX environment variable should be respected. It's kind of an relic. I'll look into it.
> NetworKit mailing list
> NetworKit at ira.uni-karlsruhe.de
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
More information about the NetworKit